Add application configuration based on build environment #1053
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
==========================================
+ Coverage 72.72% 74.28% +1.55%
==========================================
Files 12 15 +3
Lines 66 70 +4
==========================================
+ Hits 48 52 +4
Misses 18 18
Continue to review full report at Codecov.
|
|
Does someone checked this PR ? |
|
@thomasthiebaud I'm just getting back into the swing of this project. I've glanced at it, and appreciate the contribution, but it may take me a day or two to come back to considering it more thoroughly. Sorry for the delay! |
|
I just rebased this PR, so it is up-to-date |
|
Hello there @thomasthiebaud. Using the alias command means that the imported object will be included as is in the generated assets. Isn't this a problem because even the values that are not being used will be exposed to the consumer. I am using DefinePlugin to expose environment based configuration to my app, which is being evaluated in compile time and exposes only the required values. Furthermore, I am defining feature toggles (simple booleans) on my configurations where if the toggle is false, UglifyJS will drop the dead code. Neat feature! Would you consider a DefinePlugin based solution? |
This is a PR related to this issue #160
The main idea is to define an alias into
webpack.config.jswhich pointed to the right config file.It is then as simple as
to access the variable